Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export ctx.RepoRelDir to run step environment. #1063

Merged
merged 2 commits into from
Jun 2, 2020
Merged

Export ctx.RepoRelDir to run step environment. #1063

merged 2 commits into from
Jun 2, 2020

Conversation

llamahunter
Copy link
Contributor

fixes #806

@codecov
Copy link

codecov bot commented May 29, 2020 •
edited
Loading

Codecov Report

Merging #1063 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1063   +/-   ##
=======================================
  Coverage   71.47%   71.47%           
=======================================
  Files          67       67           
  Lines        5556     5557    +1     
=======================================
+ Hits         3971     3972    +1     
  Misses       1271     1271           
  Partials      314      314
Impacted Files Coverage Δ
server/events/runtime/run_step_runner.go 90.69% <100.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd9131a...268f7ea. Read the comment docs.

@llamahunter
Copy link
Contributor Author

@lkysow could this get merged and released?

lkysow
lkysow reviewed Jun 1, 2020
View reviewed changes
Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for updating the docs too! Just a small suggestion.

runatlantis.io/docs/custom-workflows.md Outdated Show resolved Hide resolved
@llamahunter
Copy link
Contributor Author

Sure. I am just exposing the existing variable that's already there in atlantis, as I don't want to try to parse it out of the full path variable by searching for the workspace name or something.

@lkysow
Copy link
Member

lkysow commented Jun 2, 2020

Oh for sure, we should have had this to start.

@lkysow lkysow merged commit 0f496c8 into runatlantis:master Jun 2, 2020
@llamahunter llamahunter deleted the repo-rel-dir-env branch June 2, 2020 00:08
@llamahunter
Copy link
Contributor Author

so... I know you just did a release, but when do you think this might go out?

@lkysow
Copy link
Member

lkysow commented Jun 2, 2020

Probably in the next week or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkysow lkysow lkysow left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo checkout root dir variable in custom flows
2 participants
@llamahunter @lkysow